[UI] Make page title sticky and remove box shadow #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally, and the header is now fixed at the top 👍 |
|
@kyungeunni this is ready for another look when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #396 .
Makes the recorder's page header static at the top of the viewport during scrolling, and removes its box shadow.
Implementation details
When we upgraded EUI we encountered some less-than-desired behavior (shown in the linked issue) where an expanded flyout leaves the title section of the page undimmed while the flyout is expanded. The true intention of this functionality is that the flyout will appear below a static heading UI, whereas ours fills in all the way to the top of the viewport.
To resolve this unwanted behavior, I've modified the page heading to be sticky, per the design standards shown in both the EUI docs and in multiple parts of Kibana. Now, when the user scrolls, the page heading will remain at the top of the viewport, and will remain accented when the flyout opens.
A side effect of this change is the removal of the box shadow; because it is highlighted while the flyout is open, it makes the title look weird. Rendering the shadow conditionally is also less-than-ideal because having it snap away when the flyout opens is also janky.
How to validate this change
You can compare this change by running the recorder in dev mode and switching between this branch and main.